refactor(schemer): move to expo/expo
#25769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
byCedric
force-pushed
the
@bycedric/refactor/schemer
branch
from
670d6f8
to
49f49fe
Compare
EvanBacon
approved these changes
Dec 8, 2023
byCedric
force-pushed
the
@bycedric/refactor/schemer
branch
from
bc1abfe
to
2cf2903
Compare
github-actions
bot
added
bot: fingerprint changed
and removed
bot: fingerprint compatible
labels
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
byCedric
force-pushed
the
@bycedric/refactor/schemer
branch
from
2cf2903
to
072d51b
Compare
github-actions
bot
added
bot: fingerprint compatible
and removed
bot: fingerprint changed
labels
byCedric
force-pushed
the
@bycedric/refactor/schemer
branch
from
072d51b
to
9ede521
Compare
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why Moving the actively used `@expo/schemer` over from `expo/expo-cli`. Currently used in: - `expo-doctor` - Our backend Counter-part PR: expo/expo-cli#4795 # How - Copied `@expo/schemer` from `expo/expo-cli` - Updated `tsconfig.json` to point at this monorepo config - Integrated `expo-module-scripts` - Added missing types packages - Updated tests to work with Jest (+ overall easier to read) - Resolved issues with snapshots - Resolved linting issues - Reconfigured e2e tests - Dropped lodash # Test Plan See if CI passes. # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Moving the actively used
@expo/schemerover fromexpo/expo-cli.Currently used in:
expo-doctorCounter-part PR: expo/expo-cli#4795
How
@expo/schemerfromexpo/expo-clitsconfig.jsonto point at this monorepo configexpo-module-scriptsTest Plan
See if CI passes.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).