feat(cli): prevent showing logs for source maps #25830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
EvanBacon
deleted the
@evanbacon/cli/prevent-showing-logs-for-sourcemaps
branch
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why <img width="904" alt="Screenshot 2023-12-08 at 8 18 34 PM" src="https://github.com/expo/expo/assets/9664363/af868d0b-6918-4bbc-b557-d2269ee935e0"> <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How Detect if a bundling event is for a map, if so, hide it from the logger. <!-- How did you build this feature or fix this bug and why? --> # Test Plan - Start dev server. - Add a bunch of modules. - Comment them out / back in. - Close/open inspector to trigger all the HMR sourcemaps being refetched. - There shouldn't be any additional request logs in the terminal. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Detect if a bundling event is for a map, if so, hide it from the logger.
Test Plan