[dev-menu] Update JS inspector URL #25881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
requested review from
lukmccall and
douglowder
as code owners
gabrieldonadel
changed the title
gabrieldonadel
force-pushed
the
@gabrieldonadel/fix-inspector
branch
from
61301c5
to
ef32cbf
Compare
byCedric
approved these changes
Dec 12, 2023
android/expoview/src/main/java/versioned/host/exp/exponent/modules/internal/DevMenuModule.kt
Outdated
Show resolved
Hide resolved
packages/expo-dev-menu/android/src/main/java/expo/modules/devmenu/api/DevMenuMetroClient.kt
Outdated
Show resolved
Hide resolved
This was referenced Dec 12, 2023
# Why Stacked on top of #25881 Correction of #25671 This was in place for the dev menu, and I deleted it a bit too early in #25671. We can only delete this once we fully swapped over to `@react-native/dev-middleware`, which is currently only used for the inspector proxy infrastructure. # How - Added back `createJsInspectorMiddleware` from #25671 # Test Plan - `$ bun create expo ./test-devmenu-debugger --template blank@50` - `$ cd ./test-devmenu-debugger` - `$ bun expo install expo-dev-client` - `$ bun expo start` - Press `m` in terminal - Press "Inspect JS" in the menu within the app # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Co-authored-by: Cedric van Putten <me@bycedric.com>
expo-bot
added
bot: passed checks
brentvatne
approved these changes
Dec 12, 2023
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why Closes ENG-10881 # How Adds back `createJsInspectorMiddleware` from expo#25671 to the CLI and update JS inspector URL on Expo GO and expo-dev-menu to use `/_expo/debugger` # Test Plan Run Expo Go unversioned and dev-client through bare expo and test opening the debugger through the dev menu on Android and iOS # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Cedric van Putten <me@bycedric.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-10881
How
Adds back
createJsInspectorMiddlewarefrom #25671 to the CLI and update JS inspector URL on Expo GO and expo-dev-menu to use/_expo/debuggerTest Plan
Run Expo Go unversioned and dev-client through bare expo and test opening the debugger through the dev menu on Android and iOS
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).