fix(cli): add missing find-yarn-workspace-root
dependency
#25991
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
@expo/cli
does not have a direct dependency reference tofind-yarn-workspace-root
, yet we import it insrc/start/server/middleware/ManifestMiddleware.ts
. This breaks isolated modules.The current implicit dependency chains are:
@expo/cli → @expo/metro-config → find-yarn-workspace-root
@expo/cli → @expo/package-manager → find-yarn-workspace-root
@expo/cli → @expo/prebuild-config → find-yarn-workspace-root
How
find-yarn-workspace-root
as dependency to@expo/cli
Test Plan
See if
yarn typecheck
has any typescript issues.Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).