[core] fix systemBackgroundColor build error on tvos #26029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukmccall
approved these changes
Dec 19, 2023
tsapeta
approved these changes
Dec 19, 2023
brentvatne
pushed a commit
that referenced
this pull request
Dec 19, 2023
# Why #26015 breaks the build on tvos: https://expo.dev/accounts/expo-ci/projects/updates-e2e/builds/a2f1abba-1712-4121-a6b0-d69c179d00a4 # How only set systemBackgroundColor on non-tvos # Test Plan ci passed: https://expo.dev/accounts/expo-ci/projects/updates-e2e/builds/2f54cf61-ae0d-4890-a7e7-64d907ae10e1 # Checklist - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why expo#26015 breaks the build on tvos: https://expo.dev/accounts/expo-ci/projects/updates-e2e/builds/a2f1abba-1712-4121-a6b0-d69c179d00a4 # How only set systemBackgroundColor on non-tvos # Test Plan ci passed: https://expo.dev/accounts/expo-ci/projects/updates-e2e/builds/2f54cf61-ae0d-4890-a7e7-64d907ae10e1 # Checklist - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#26015 breaks the build on tvos: https://expo.dev/accounts/expo-ci/projects/updates-e2e/builds/a2f1abba-1712-4121-a6b0-d69c179d00a4
How
only set systemBackgroundColor on non-tvos
Test Plan
ci passed: https://expo.dev/accounts/expo-ci/projects/updates-e2e/builds/2f54cf61-ae0d-4890-a7e7-64d907ae10e1
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).