[expo-updates][7/n] Remove classic updates #26080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschurman
force-pushed
the
@wschurman/remove-more-classic-updates-stuff-7
branch
from
b89d1f0
to
079b240
Compare
wschurman
force-pushed
the
@wschurman/remove-more-classic-updates-stuff-6
branch
from
4e90546
to
d2885e2
Compare
wschurman
force-pushed
the
@wschurman/remove-more-classic-updates-stuff-7
branch
from
079b240
to
3cbc661
Compare
wschurman
force-pushed
the
@wschurman/remove-more-classic-updates-stuff-6
branch
from
d2885e2
to
e937db4
Compare
wschurman
force-pushed
the
@wschurman/remove-more-classic-updates-stuff-7
branch
from
3cbc661
to
fc1d830
Compare
wschurman
force-pushed
the
@wschurman/remove-more-classic-updates-stuff-6
branch
from
e937db4
to
9e824cd
Compare
wschurman
force-pushed
the
@wschurman/remove-more-classic-updates-stuff-7
branch
from
fc1d830
to
ca87ada
Compare
wschurman
force-pushed
the
@wschurman/remove-more-classic-updates-stuff-6
branch
from
9e824cd
to
158f617
Compare
wschurman
force-pushed
the
@wschurman/remove-more-classic-updates-stuff-7
branch
from
ca87ada
to
01c41fa
Compare
wschurman
requested review from
ide,
tsapeta,
brentvatne and
douglowder
as code owners
wschurman
requested review from
EvanBacon
and removed request for
brentvatne and
tsapeta
ide
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
LGTM. Looks like a "green flag" to remove a dependency between Expo.fx.ts and expo-updates.
For the changelog, I might suggest phrasing this as the expo package no longer does verification at run time that a runtime version is set in apps that use expo-updates, because expo-updates will disable itself when a runtime version is not defined or if the updates configuration is invalid for any other reason.
tsapeta
approved these changes
Dec 28, 2023
wschurman
force-pushed
the
@wschurman/remove-more-classic-updates-stuff-6
branch
from
158f617
to
68fb97f
Compare
wschurman
requested review from
Simek,
amandeepmittal,
lukmccall,
gabrieldonadel and
byCedric
as code owners
wschurman
force-pushed
the
@wschurman/remove-more-classic-updates-stuff-7
branch
2 times, most recently
from
9df6b9e
to
f475936
Compare
expo-bot
added
bot: passed checks
wschurman
removed request for
EvanBacon,
Simek,
amandeepmittal,
lukmccall,
gabrieldonadel and
byCedric
wschurman
force-pushed
the
@wschurman/remove-more-classic-updates-stuff-6
branch
from
68fb97f
to
54c164b
Compare
Base automatically changed from
@wschurman/remove-more-classic-updates-stuff-6
to
main
January 3, 2024 00:38
wschurman
force-pushed
the
@wschurman/remove-more-classic-updates-stuff-7
branch
from
f475936
to
15248c9
Compare
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This removes the
isMissingRuntimeVersionconstant from expo-updates. This constant no longer makes sense since disabled is an expected mode of this library, and a warning is shown in native logs.The code in
Expo.fx.tsxwould show a warning in dev, but in prod the top-level-thrown error actually wouldn't do anything except maybe prevent continued evaluation of the module code. The error wasn't shown anywhere as far as I can tell and the app still ran.This was originally added in #11367.
Closes ENG-10957.
How
Remove it.
Test Plan
Inspect.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).