[core][android] Adjust proguard #26108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
alanjhughes
requested review from
tsapeta,
Kudo and
lukmccall
as code owners
tsapeta
approved these changes
Dec 24, 2023
Kudo
approved these changes
Dec 25, 2023
lukmccall
approved these changes
Jan 4, 2024
alanjhughes
added a commit
that referenced
this pull request
Jan 10, 2024
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #26056
How
-keepclassmembersseems to lose the primary constructor. I'm not sure why the problem isn't seen more often so maybe @lukmccall knows more.Test Plan