Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packages] remove deprecated react native gradle dependencies #26237

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Jan 4, 2024

Why

the com.facebook.react:react-native:+ gradle dependency is dangerous and deprecated

How

replaced com.facebook.react:react-native:+ with com.facebook.react:react-android

Test Plan

ci passed

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 4, 2024
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jan 4, 2024
@Kudo Kudo marked this pull request as ready for review January 4, 2024 07:11
Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I thought that we already removed it 😲

@Kudo Kudo merged commit 7222d4e into main Jan 4, 2024
16 checks passed
@Kudo Kudo deleted the @kudo/remove-deprecated-android-dep branch January 4, 2024 10:56
Kudo added a commit that referenced this pull request Jan 10, 2024
the `com.facebook.react:react-native:+` gradle dependency is dangerous
and deprecated

replaced `com.facebook.react:react-native:+` with
`com.facebook.react:react-android`

(cherry picked from commit 7222d4e)
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Jan 10, 2024
onizam95 pushed a commit to onizam95/expo-av-drm that referenced this pull request Jan 15, 2024
…6237)

# Why

the `com.facebook.react:react-native:+` gradle dependency is dangerous
and deprecated

# How

replaced `com.facebook.react:react-native:+` with
`com.facebook.react:react-android`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants