Add macOS support to expo-font #26242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
force-pushed
the
@tsapeta/macos/expo-font
branch
from
98023ca
to
15034ed
Compare
alanjhughes
approved these changes
Jan 4, 2024
expo-bot
added
bot: passed checks
tsapeta
added a commit
that referenced
this pull request
Jan 10, 2024
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Following up on #26186, separated from #22796
expo-fontis a dependency of theexpopackage, so we need to make it compatible with macOS in order to support writing Expo modules for macOSHow
ExpoModulesCore/Platform.hcustomNativeFontsconstant with an empty array for now, in the future we should add support forATSApplicationFontsPathkey in the Info.plistTest Plan
Tested in https://github.com/tsapeta/expo-macos-example as part of PR #22796