Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS support to the expo package #26283

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Jan 6, 2024

Why

expo is the last package that needs to declare support for macOS in order to install Expo modules in macOS target.

How

  • Added macOS platform to the podspec of the expo package
  • Reinstalled pods

Test Plan

Tested in https://github.com/tsapeta/expo-macos-example

@tsapeta tsapeta marked this pull request as ready for review January 6, 2024 09:50
@tsapeta tsapeta requested a review from Kudo January 6, 2024 09:50
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 6, 2024
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@tsapeta tsapeta merged commit 5f564f2 into main Jan 6, 2024
1 check passed
@tsapeta tsapeta deleted the @tsapeta/macos/expo-package branch January 6, 2024 12:31
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jan 6, 2024
tsapeta added a commit that referenced this pull request Jan 10, 2024
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Jan 10, 2024
onizam95 pushed a commit to onizam95/expo-av-drm that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants