Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[constants] Remove deprecated constants #26329

Merged
merged 10 commits into from
Jan 23, 2024

Conversation

aleqsio
Copy link
Contributor

@aleqsio aleqsio commented Jan 9, 2024

Why

Suggested by @tsapeta, we have a whole host of deprecated properties from expo-constants that we can remove at this point.

One exception is the manifest field, that is still used by expo-constants JS code, so we keep it in native code and types, but we hide in the docs.

It can conflict with #26313, so let's wait with merging this PR until that one is merged.
CC @wschurman

Test Plan

Tested in bare-expo.

Checklist

Copy link
Member

@wschurman wschurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change before commit is to revert the removal of manifest field and optionally remove the warning as noted inline. Other than that, this looks great!

@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against e5121ab

@aleqsio aleqsio merged commit b877714 into main Jan 23, 2024
13 checks passed
@aleqsio aleqsio deleted the @aleqsio/remove-deprecated-constants branch January 23, 2024 13:06
@wschurman wschurman mentioned this pull request Jan 23, 2024
3 tasks
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: suggestions ExpoBot has some suggestions published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants