-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[constants] Remove deprecated constants #26329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only change before commit is to revert the removal of manifest
field and optionally remove the warning as noted inline. Other than that, this looks great!
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
Why
Suggested by @tsapeta, we have a whole host of deprecated properties from expo-constants that we can remove at this point.
One exception is the
manifest
field, that is still used by expo-constants JS code, so we keep it in native code and types, but we hide in the docs.It can conflict with #26313, so let's wait with merging this PR until that one is merged.
CC @wschurman
Test Plan
Tested in bare-expo.
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).