Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image-picker] convert WEBP to PNG instead JPEG #26419

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

NikitaDudin
Copy link
Contributor

@NikitaDudin NikitaDudin commented Jan 15, 2024

Why

JPEG format doesn't support alpha channel.

How

Convert WEBP to PNG instead JPEG when selecting an image in the Media Library with active allowEditing option.
Add webp to supported image file extensions list. Received file path ends with .webp instead .jpeg for WEBP image with options { quality: 1, allowEditing: false }.

Test Plan

  • Manually test

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jan 15, 2024
@NikitaDudin NikitaDudin marked this pull request as draft January 15, 2024 11:25
@NikitaDudin NikitaDudin force-pushed the feature/image-picker-webp branch 2 times, most recently from b0375a5 to 97dbc9a Compare January 15, 2024 12:22
@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions and removed bot: passed checks ExpoBot has nothing to complain about labels Jan 15, 2024
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jan 15, 2024
@NikitaDudin NikitaDudin marked this pull request as ready for review January 15, 2024 12:26
Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏅
Thanks for your contribution.
I'll merge your PR if the CI passes.

@lukmccall lukmccall merged commit 61ca98a into expo:main Feb 5, 2024
9 of 10 checks passed
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants