[router]: allow custom file extension for renderRouter
#26510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
…m:expo/expo into marklawlor/router/context-stub-extensions
github-actions
bot
added
bot: fingerprint compatible
and removed
bot: fingerprint changed
labels
EvanBacon
approved these changes
Jan 22, 2024
marklawlor
added a commit
that referenced
this pull request
Feb 28, 2024
`renderRouter` currently appends `.js` to all filenames. This is
undocumented and also makes writing tests that depend on the extension
(e.g. duplicate routes) difficult.
This change will only append `.js` is no valid extension is provided.
E.g this is now allowed and allows for better duplicate route tests.
```
renderRouter({
"(app)/page.js": () => null,
"(app)/page.tsx": () => null,
});
```
There are many duplicate route tests as part of the `getRoutes()` PR.
I'm separating this logic to reduce the size of the PR
The tests for this will be part of the `getRoutes` refactor PR
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
---------
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
renderRoutercurrently appends.jsto all filenames. This is undocumented and also makes writing tests that depend on the extension (e.g. duplicate routes) difficult.This change will only append
.jsis no valid extension is provided.E.g this is now allowed and allows for better duplicate route tests.
How
There are many duplicate route tests as part of the
getRoutes()PR. I'm separating this logic to reduce the size of the PRTest Plan
The tests for this will be part of the
getRoutesrefactor PRChecklist
npx expo prebuild& EAS Build (eg: updated a module plugin).