[screen-capture] Fix callback on api 34 #26549

alanjhughes · 2024-01-20T13:45:51Z

Why

Android 14 requires the permission DETECT_SCREEN_CAPTURE to listen for changes. We can also use a new activity callback on api 34.

Added the permission and used the Activity callback when running on Android 14.

Tested in provided repro on physical device running android 14
If someone with a device running android 13 can test because the callbacks don't fire in the emulator cc @lukmccall

linear · 2024-01-20T13:45:54Z

jatinhemnani01 · 2024-02-28T08:00:05Z

Hey @alanjhughes, I'm using this package and the addScreenshotListener isn't working on Android

[screen-capture] Fix callback on api 34

79641e5

alanjhughes requested a review from lukmccall January 20, 2024 13:46

expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 20, 2024

[screen-capture] changelog

b5d7fa3

expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jan 20, 2024

github-actions bot added the bot: fingerprint changed label Jan 20, 2024

lukmccall approved these changes Jan 22, 2024

View reviewed changes

alanjhughes marked this pull request as ready for review January 22, 2024 11:07

alanjhughes requested a review from tsapeta as a code owner January 22, 2024 11:07

alanjhughes merged commit 650ffd8 into main Jan 22, 2024
9 checks passed

alanjhughes deleted the @alanhughes/fix/screenshot-api-34 branch January 22, 2024 11:15

alanjhughes added a commit that referenced this pull request Jan 22, 2024

[screen-capture] Fix callback on api 34 (#26549)

7a1bcd6

brentvatne added the published Changes from the PR have been published to npm label Jan 23, 2024