feature(cli): allow using github url as template when prebuilding #26631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
force-pushed
the
@bycedric/cli/template-github-url
branch
from
8ab8b0b
to
c8d3025
Compare
github-actions
bot
added
bot: fingerprint changed
and removed
bot: fingerprint compatible
labels
byCedric
commented
Jan 23, 2024
Comment on lines
112
to
117
| ignore: [ | ||
| '**/.gitattributes', | ||
| '**/.npmignore', | ||
| '**/ios/HelloWorld.xcworkspace/**', | ||
| '**/ios/.xcode.env.local', | ||
| ], |
There was a problem hiding this comment.
Let me try if we can add inverse ignores. If we keep dot: false (default), and explicitly add !**/ios/.xcode.env as ignore, we could get rid of some options here.
There was a problem hiding this comment.
Negative ignores breaks picomatch, but we can provide multiple globs in the filter.
expo-bot
added
bot: passed checks
EvanBacon
approved these changes
Jan 23, 2024
3 tasks
byCedric
added a commit
that referenced
this pull request
Jan 23, 2024
# Why Backporting from #26631 # How - Added filtering logic from `expo prebuild --template <github-url>` # Test Plan See tests - `$ bun create expo ./test --template expo-template-bare-minimum@49` - `$ cd ./test` - `$ rm -rf android ios` - `$ bun expo prebuild` - `$ git add . && git commit -m 'chore: initial prebuild'` - Delete everything, except `.git` - `$ create-expod . --no-install --template https://github.com/expo/expo/tree/sdk-49/templates/expo-template-bare-minimum` - Configure `com.test` in `app.json` as `android.package` and `ios.bundleIdentifier` - `$ bun install && bun expo prebuild --clean` - Result should pretty much be the same (there might be some differences in lockfiles and native files 🤷) > ℹ️ In these examples `create-expod` is an alias for `node <create-expo>/build/index.js` # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
byCedric
added a commit
that referenced
this pull request
Jan 23, 2024
…6631) # Why Porting functionality over from #26554 to `expo prebuild --template ...` # How - Added Tar `createGlobFilter` based on `picomatch` - Implemented identical `strip` and `filter` strategies from `create-expo` - Fixed template name when running `prebuild` with a git template # Test Plan - `$ bun create expo ./test --template expo-template-bare-minimum@49` - `$ cd ./test` - `$ bun install && bun expo prebuild --no-install` - `$ git commit -m 'chore: initial changes'` - `$ expod prebuild --no-install --template https://github.com/expo/expo/tree/sdk-49/templates/expo-template-bare-minimum` - Result should be similar. One cool thing here is that you can even specify specific commit in the template. E.g. ``` $ expod prebuild --no-install --template https://github.com/expo/expo/tree/30072b9637f0d2b964fe7f47f99f0e369336913a/templates/expo-template-bare-minimum ``` This would help us testing unreleased canaries, fixes and other stuff 😄 # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Porting functionality over from #26554 to
expo prebuild --template ...How
createGlobFilterbased onpicomatchstripandfilterstrategies fromcreate-expoprebuildwith a git templateTest Plan
$ bun create expo ./test --template expo-template-bare-minimum@49$ cd ./test$ bun install && bun expo prebuild --no-install$ git commit -m 'chore: initial changes'$ expod prebuild --no-install --template https://github.com/expo/expo/tree/sdk-49/templates/expo-template-bare-minimumOne cool thing here is that you can even specify specific commit in the template. E.g.
This would help us testing unreleased canaries, fixes and other stuff 😄
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).