fix(cli): only show web ready in expo start when enabled
#26694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
byCedric
added a commit
that referenced
this pull request
Jan 25, 2024
# Why Fixes #26519 With Metro being the default (web) bundler, the "Web is waiting on ..." message incorrectly popped up (before web dependencies are installed, and opt-in through `expo.platforms: [..., 'web']`. When opening the link, without actually enabling web support, users received the Expo Go manifest. # How - Check if platform web is explicitly enabled in `DevServerManagerActions` (by checking `this.options.platforms?.includes('web')` # Test Plan - `$ bun create expo ./test --template blank@50` - `$ cd ./test` - `$ expod start` Before | after --- | ---  |  - Press <kbd>w</kbd> Should see: <img width="860" alt="image" src="https://github.com/expo/expo/assets/1203991/ce01bda2-703b-4a0c-bcdf-487a1bce1817"> - `$ bun expo install react-native-web react-dom @expo/metro-runtime` - `$ expod start` - This should now show "Web is waiting on ..." # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #26519
With Metro being the default (web) bundler, the "Web is waiting on ..." message incorrectly popped up (before web dependencies are installed, and opt-in through
expo.platforms: [..., 'web'].When opening the link, without actually enabling web support, users received the Expo Go manifest.
How
DevServerManagerActions(by checkingthis.options.platforms?.includes('web')Test Plan
$ bun create expo ./test --template blank@50$ cd ./test$ expod startShould see:
$ bun expo install react-native-web react-dom @expo/metro-runtime$ expod startChecklist
npx expo prebuild& EAS Build (eg: updated a module plugin).