[router] add pop/popToTop/canPop #26711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklawlor
requested review from
Simek,
amandeepmittal and
EvanBacon
as code owners
expo-bot
added
bot: passed checks
marklawlor
force-pushed
the
marklawlor/router/pushToTop
branch
from
cd34e7a
to
cf537ac
Compare
github-actions
bot
added
bot: fingerprint compatible
and removed
bot: fingerprint changed
labels
EvanBacon
reviewed
Jan 29, 2024
docs/pages/router/advanced/stack.mdx
Outdated
|
|
||
| ### `pop` action | ||
|
|
||
| Go back in the stack by the number of screens specified in the `count` parameter. If no `count` is specified, then it will go back to the previous screen in the stack. |
There was a problem hiding this comment.
It should be clear how this differs from "goBack"
EvanBacon
reviewed
Jan 29, 2024
| ); | ||
| } | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Maybe add a goBack vs pop example section in here.
|
Rename to |
marklawlor
force-pushed
the
marklawlor/router/pushToTop
branch
2 times, most recently
from
789e4dd
to
f2e28ee
Compare
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
marklawlor
force-pushed
the
marklawlor/router/pushToTop
branch
from
f2e28ee
to
552611d
Compare
marklawlor
added a commit
that referenced
this pull request
Feb 28, 2024
# Why Add `pop`/`popToTop`/`canTop` to the router apis (both hooks and imperative). # How <!-- How did you build this feature or fix this bug and why? --> # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Add
pop/popToTop/canTopto the router apis (both hooks and imperative).How
Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).