[secure-store] Add canUseBiometricAuthentication function
#26767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukmccall
approved these changes
Jan 29, 2024
packages/expo-secure-store/android/src/main/java/expo/modules/securestore/SecureStoreModule.kt
Outdated
Show resolved
Hide resolved
expo-bot
added
bot: passed checks
amandeepmittal
approved these changes
Jan 30, 2024
tsapeta
approved these changes
Jan 30, 2024
behenate
deleted the
@behenate/secure-store-add-can-require-authentication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
fixes #26777
Secure-store will throw an error when trying to save a value with
requireAuthenticationset totruebut no biometrics (or insufficient biometrics) are enrolled. This is good, but it's the only way (without usingexpo-local-authentication) of checking if the value can be saved. This is not ideal.This PR adds a small convenience function that allows our users to check if
requireAuthenticationcan be used before saving the value.Any suggestions for a better name for the method are appreciated! 馃槃
How
On Android used existing assertion function, handled the exception by returning
falseif it occurred, otherwisetrue. On iOS usedLAContextto check currently enrolled biometrics.Test Plan
Tested in BareExpo on iOS 16 and Android 13 devices.