Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] Run Android Studio code formatter for all .gradle files #2681

Merged
merged 2 commits into from Nov 13, 2018

Conversation

sjchmiela
Copy link
Contributor

Why

To make #2446 easier to review and cause it's nice to have files formatted properly.

How

Iterated manually through every Gradle file visible in the left pane of Android Studio and for each ran Reformat Code command.

Test Plan

Project synced without problems.

Copy link
Contributor

@bbarthec bbarthec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about packages/expo-module-template/android/build.gradle?

@sjchmiela sjchmiela merged commit 0c238c1 into master Nov 13, 2018
@sjchmiela sjchmiela deleted the @sjchmiela/reformat_gradle_files branch November 13, 2018 11:50
ronlaureles pushed a commit to ronlaureles/expo that referenced this pull request May 20, 2019
…po#2681)

* Run Android Studio code formatter for all .gradle files in android project

* Post-review fixes
prakashbask pushed a commit to prakashbask/expo that referenced this pull request Mar 16, 2022
…po#2681)

* Run Android Studio code formatter for all .gradle files in android project

* Post-review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants