fix(router): fix issue with top-level catch-all not being matched in server renderer #26861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
EvanBacon
added a commit
that referenced
this pull request
Feb 1, 2024
…server renderer (#26861) - The server manifest was supporting non-optional `[[...a]]` syntax, which isn't supported in the client router and would require a breaking change to add. This resulted in a forked behavior between client-side routing and server-side routing. This change treats `[...a]` as optional catch-alls (matching `/` and `/a`) to behave the same across routers. - Added unit tests - A project with just `app/[...a].tsx` will work in server and static rendering modes. <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
[[...a]]syntax, which isn't supported in the client router and would require a breaking change to add. This resulted in a forked behavior between client-side routing and server-side routing. This change treats[...a]as optional catch-alls (matching/and/a) to behave the same across routers.Test Plan
app/[...a].tsxwill work in server and static rendering modes.Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).