Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ios][camera] Fix maxDuration on videos #26882

Merged
merged 2 commits into from
Feb 2, 2024
Merged

[ios][camera] Fix maxDuration on videos #26882

merged 2 commits into from
Feb 2, 2024

Conversation

alanjhughes
Copy link
Collaborator

@alanjhughes alanjhughes commented Feb 2, 2024 •
edited

Why

Closes #26865
Closes ENG-11316

How

Set the correct timescale on the videos maxRecordedDuration

Test Plan

Bare-expo + NCL

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Feb 2, 2024
@alanjhughes alanjhughes marked this pull request as ready for review February 2, 2024 13:07
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Feb 2, 2024
@linear Linear
Copy link

linear bot commented Feb 2, 2024

ENG-11316 expo-camera recordAsync option type annotation states the value is in seconds, when it is in fact in milliseconds

@alanjhughes alanjhughes merged commit ee20db3 into main Feb 2, 2024
9 checks passed
@alanjhughes alanjhughes deleted the @alanhughes/camera/fix-timescale branch February 2, 2024 16:58
alanjhughes added a commit that referenced this pull request Feb 5, 2024
@alanjhughes
[ios][camera] Fix maxDuration on videos (#26882)
2be0d2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukmccall lukmccall lukmccall approved these changes

Assignees
No one assigned
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
3 participants
@alanjhughes @lukmccall @expo-bot