[camera] Fix type casing #26900
Merged
[camera] Fix type casing #26900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
lukmccall
approved these changes
Feb 5, 2024
alanjhughes
force-pushed
the
@alanhughes/camera/type-casing
branch
from
c00f5c0
to
db667ac
Compare
brentvatne
approved these changes
Feb 5, 2024
expo-bot
added
bot: suggestions
expo-bot
added
bot: passed checks
alanjhughes
added a commit
that referenced
this pull request
Feb 7, 2024
This was referenced Feb 10, 2024
| @@ -1,3 +1,3 @@ | |||
| { | |||
| "expo.jsEngine": "jsc" | |||
| "expo.jsEngine": "hermes" | |||
There was a problem hiding this comment.
Any specific reason why we changed this? As far as I remember we don't use JS at all in this app
There was a problem hiding this comment.
The Shared object tests were failing on jsc. I bumped the Xcode version and switched to Hermes and it worked a lot better. I think we went back to Xcode 14 so maybe this needs to be changed but might have the same issue with the tests.
There was a problem hiding this comment.
Imho we should switch it back to JSC, for these reasons:
- it wouldn't need to download and link hermes (faster build, but probably not that much since it's no longer built from sources)
- we don't test JSC at all since we added support for Hermes, so I intentionally used JSC here to at least have some small coverage 😅
I know these tests started failing at some point, but I think we should fix that issue instead of changing the engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-11235
The casing on everything related to barcodes was inconsistent causing problems with autocomplete
How
Fixed all instances of
Barcodein the next package to be consistentTest Plan