[Android](Camera)Fixed wrong type casting #2692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for it \o/ |
sjchmiela
reviewed
Nov 14, 2018
...xpo-camera/android/src/main/java/expo/modules/camera/tasks/ResolveTakenPictureAsyncTask.java
Outdated
Show resolved
Hide resolved
|
Also, please add a CHANGELOG.md entry 🙂 |
sjchmiela
force-pushed
the
@szymon/camera_fix_android
branch
from
328c9a6
to
bf5990c
Compare
sjchmiela
force-pushed
the
@szymon/camera_fix_android
branch
from
dfa6698
to
efc56e4
Compare
|
i have a detached app with expo sdk 30; i did the edit of the java file as suggested but how am i supposed to apply the edit to the app? restarting the packager, doing yarn install, rebuilding android project gives no result and the bug of the quality camera for android is still there |
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
* Fixed wrong type casting * Add CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #2683
How
Quality passed in
QUALITY_KEYshould be treated asdouble, not anint.Test Plan
None.