Fix linking expo package when Expo autolinking is not used
#26932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
force-pushed
the
@tsapeta/warn-about-missing-autolinking
branch
from
9da7f1c
to
85a3c16
Compare
expo-bot
added
bot: passed checks
lukmccall
approved these changes
Feb 5, 2024
brentvatne
approved these changes
Feb 5, 2024
Co-authored-by: Brent Vatne <brentvatne@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This
react-native.config.jsis a nice way to preventexpopackage being linked when Expo modules are not set. However, this is not perfect, especially that we now support out of tree platforms (i.e. the config doesn't handle macOS right now).Currently, running
pod installin areact-native-macosproject that hasexpoin dependencies but doesn't have the setup for Expo autolinking would fail because it's unable to find pod specification forExpoModulesCore(which cannot be linked by React Native Community CLI).How
When
use_expo_modules!is not defined, don't include the dependency onExpoModulesCoreand print appropriate warning instead.Sadly, this doesn't fix the problem when autolinking is imported but
use_expo_modules!is not used. I'm not sure if we can do something with that, but this solution seems to be better than nothing.Test Plan
npx react-native initnpm install exponpx react-native-macos-initdoesn't fail onpod installstep and shows the warning that instructs me to set up Expo modules