-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] no more migrators from expo build #26961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amandeepmittal one weird thing i noticed is that all builds documents are under the expo/docs/constants/navigation.js Lines 474 to 477 in b6ff87f
What do you think about this plan:
|
Also can someone confirm that we actually do want to deprecate this doc |
This sounds perfect! Apologies, I didn't pay attention to the |
cc: @brentvatne |
📘 Your docs preview website is ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
# Why <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> Follow up #26961 (comment) to organize classic builds section. # How <!-- How did you build this feature or fix this bug and why? --> This PR: - Replaces `/classic-updates/` prefix with `/classic-builds/` for docs in the Classic Builds section. - Update redirects based on above. - Also updates "Migrate from expo build" sidebar title # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> Run docs locally and visit: http://localhost:3002/archive/classic-builds/building-standalone-apps/ & http://localhost:3002/archive/classic-builds/turtle-cli/ ## Preview ![CleanShot 2024-02-09 at 01 51 53@2x](https://github.com/expo/expo/assets/10234615/3af2bd78-6526-406d-8fb1-5fa07ee4da4b) # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Why
Are people still migrating from classic builds? It's been so long since we've shut it off, it may be better off archived.
How
Test Plan
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).