Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] no more migrators from expo build #26961

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Feb 7, 2024

Why

Are people still migrating from classic builds? It's been so long since we've shut it off, it may be better off archived.

How

  • move expo build migration to archive
  • add redirects to archive

Test Plan

  • manually inspected

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Feb 7, 2024
Copy link
Member

@amandeepmittal amandeepmittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of migrating it to /classic-updates/, I'd suggest archiving this doc under Classic Builds.

CleanShot 2024-02-07 at 14 05 51@2x

I know this deprecated doc contains info about page but the main focus I think is expo build to EAS Build.

@quinlanj
Copy link
Member Author

quinlanj commented Feb 7, 2024

@amandeepmittal one weird thing i noticed is that all builds documents are under the classic-updates folder and there is no classic-builds folder (now that you mention it, that's probably not intended?)

const archive = [
makeSection('Classic Builds', [
makePage('archive/classic-updates/building-standalone-apps.mdx'),
makePage('archive/classic-updates/turtle-cli.mdx'),

What do you think about this plan:

  • In this PR, we can make the classic-builds folder and move the article there
  • in a followup pr, we could move everything else that was incorrectly classified under classic-updates to classic-builds. Happy to do it, if you'd like :)

@quinlanj
Copy link
Member Author

quinlanj commented Feb 7, 2024

Also can someone confirm that we actually do want to deprecate this doc

@amandeepmittal
Copy link
Member

@amandeepmittal one weird thing i noticed is that all builds documents are under the classic-updates folder and there is no classic-builds folder (now that you mention it, that's probably not intended?)

const archive = [
makeSection('Classic Builds', [
makePage('archive/classic-updates/building-standalone-apps.mdx'),
makePage('archive/classic-updates/turtle-cli.mdx'),

What do you think about this plan:

  • In this PR, we can make the classic-builds folder and move the article there
  • in a followup pr, we could move everything else that was incorrectly classified under classic-updates to classic-builds. Happy to do it, if you'd like :)

This sounds perfect! Apologies, I didn't pay attention to the classic-builds folder not existing before, but that's a great catch! Let's not block this PR, and I can follow up with migration from classic-updates to classic-builds 😄

@amandeepmittal
Copy link
Member

Also can someone confirm that we actually do want to deprecate this doc

cc: @brentvatne

@expo-bot
Copy link
Collaborator

expo-bot commented Feb 7, 2024

📘 Your docs preview website is ready!

Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@quinlanj quinlanj merged commit 18e4a53 into main Feb 8, 2024
6 checks passed
@quinlanj quinlanj deleted the @quin/classic-builds branch February 8, 2024 18:01
amandeepmittal added a commit that referenced this pull request Feb 9, 2024
# Why

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

Follow up
#26961 (comment) to
organize classic builds section.

# How

<!--
How did you build this feature or fix this bug and why?
-->

This PR:
- Replaces `/classic-updates/` prefix with `/classic-builds/` for docs
in the Classic Builds section.
- Update redirects based on above.
- Also updates "Migrate from expo build" sidebar title

# Test Plan

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

Run docs locally and visit:
http://localhost:3002/archive/classic-builds/building-standalone-apps/ &
http://localhost:3002/archive/classic-builds/turtle-cli/

## Preview

![CleanShot 2024-02-09 at 01 51
53@2x](https://github.com/expo/expo/assets/10234615/3af2bd78-6526-406d-8fb1-5fa07ee4da4b)


# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants