Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metro-config): Add support for splitting on require.resolveWeak syntax. #27014

Merged
merged 2 commits into from
Feb 9, 2024
Merged

feat(metro-config): Add support for splitting on require.resolveWeak syntax. #27014

merged 2 commits into from
Feb 9, 2024

Conversation

EvanBacon
Copy link
Contributor

Why

  • Split out of RSC branch. Supports adding references to async imports without bundling them.

How

Test Plan

  • Added an e2e bundling test.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Feb 9, 2024
@EvanBacon @expo-bot
Update packages/@expo/metro-config/CHANGELOG.md
42ba6d8 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@EvanBacon EvanBacon merged commit cb5a3d2 into main Feb 9, 2024
5 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/metro-config/split-on-weak branch February 9, 2024 00:36
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Feb 9, 2024
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byCedric byCedric Awaiting requested review from byCedric byCedric is a code owner

@marklawlor marklawlor Awaiting requested review from marklawlor marklawlor is a code owner

Assignees
No one assigned
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EvanBacon @brentvatne @expo-bot