refactor(cli): enable lazy swc bundling #27061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
byCedric
force-pushed
the
@bycedric/cli/lazy-bundling
branch
from
ead4dfc
to
3b5a91e
Compare
github-actions
bot
added
bot: fingerprint changed
and removed
bot: fingerprint compatible
labels
EvanBacon
approved these changes
Feb 12, 2024
|
Relevant tests passed, with an exception for the updates e2e on EAS. But that has nothing to do with the CLI 😄 |
3 tasks
Kudo
added a commit
that referenced
this pull request
Apr 19, 2024
# Why fixing an error `TypeError: osascript(...) is not a function` when pressing "j" to launch js debugger this is a regression from #27061 and actually a bug from swc # How upgrade swc fixed the problem, maybe a relevant fix is swc-project/swc@0a7ca2f? it's near release stage and i don't want to upgrade swc 1.4. let's stick on 1.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This should boost startup performance a bit. Tested with
bun create expo ./test --template tabs.1:
expo export --platform web(75-100ms improvement)2:
expo export -p ios --no-bytecode --no-minify --max-workers=0 --clear --dev(±300ms improvement)How
See hyperfine screenshots above
Other tests
18+, adds back100msto export performance to test 2Node target 18+Test Plan
See tests
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).