Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): add more tests for export:embed #27114

Merged
merged 4 commits into from Feb 16, 2024
Merged

chore(cli): add more tests for export:embed #27114

merged 4 commits into from Feb 16, 2024

Conversation

EvanBacon
Copy link
Contributor

Why

  • Need to make some changes to this command for Router v4, adding tests will help with regressions.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Feb 15, 2024
@EvanBacon @expo-bot
Update packages/@expo/cli/CHANGELOG.md
005a562 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Feb 15, 2024
byCedric
byCedric approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@byCedric byCedric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice-job

@EvanBacon EvanBacon merged commit 417497b into main Feb 16, 2024
6 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/cli/unify-exporting-a-bit branch February 16, 2024 19:13
@EvanBacon EvanBacon mentioned this pull request Feb 22, 2024
Closed
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byCedric byCedric byCedric approved these changes

Assignees
No one assigned
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EvanBacon @byCedric @brentvatne @expo-bot