Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][screen-capture] Reverse api constraint on permission #27148

Merged

Conversation

alanjhughes
Copy link
Collaborator

Why

The api constraint on the permission should be reversed. Noticed this while looking into another issue.

How

Change from maxSdkVersion to minSdkVersion

Test Plan

Test project. Still works as expected

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Feb 17, 2024
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Feb 17, 2024
@alanjhughes alanjhughes marked this pull request as ready for review February 17, 2024 19:52
@alanjhughes alanjhughes merged commit 0f51817 into main Feb 17, 2024
9 checks passed
@alanjhughes alanjhughes deleted the @alanhughes/screen-capture/reverse-permission-constraint branch February 17, 2024 20:29
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants