Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix critical issue with web dev urls #27213

Merged
merged 4 commits into from Feb 21, 2024

Conversation

EvanBacon
Copy link
Contributor

Why

The wrong URL was being used for development, we don't have any tests to cover this case so it wasn't flagged during the refactor.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Feb 21, 2024
EvanBacon and others added 2 commits February 21, 2024 12:56
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Feb 21, 2024
@EvanBacon EvanBacon merged commit 76fad0f into main Feb 21, 2024
6 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/cli/fix-web-url branch February 21, 2024 19:16
aleqsio pushed a commit that referenced this pull request Feb 22, 2024
# Why

The wrong URL was being used for development, we don't have any tests to
cover this case so it wasn't flagged during the refactor.

---------

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants