[camera][web] prevent creating a webworker in non-browser environments #27222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
alanjhughes
approved these changes
Feb 22, 2024
lukmccall
approved these changes
Feb 22, 2024
lukmccall
changed the title
aleqsio
pushed a commit
that referenced
this pull request
Feb 22, 2024
#27222) # Why Fix #27194 Expo Router is rendering the page on the server, where the Worker global does not exist. # How `createWorkerAsyncFunction` starts a webworker and returns a `decode` function. This function should never be called on the server (it should be from a user event), so when rendering on the server we stub the `decode` function and never create the webworker. # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fix #27194
Expo Router is rendering the page on the server, where the Worker global does not exist.
How
createWorkerAsyncFunctionstarts a webworker and returns adecodefunction. This function should never be called on the server (it should be from a user event), so when rendering on the server we stub thedecodefunction and never create the webworker.Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).