Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli) warn when shared schemes fail to be resolved #27241

Merged
merged 6 commits into from
Feb 23, 2024
Merged

feat(cli) warn when shared schemes fail to be resolved #27241

merged 6 commits into from
Feb 23, 2024

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Feb 23, 2024 •
edited

Why

Test Plan

  • Added tests for the various different scheme conditions.

@linear Linear
Copy link

linear bot commented Feb 23, 2024

ENG-9095 Dev client mode in Expo CLI no longer points to {scheme}://expo-development-client/?url=… anymore

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Feb 23, 2024
EvanBacon and others added 2 commits February 22, 2024 19:14
@EvanBacon
add tests
b121bc9
@EvanBacon @expo-bot
Update packages/@expo/cli/CHANGELOG.md
3b59d3f 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Feb 23, 2024
brentvatne
brentvatne approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, thank you ❤️

@EvanBacon EvanBacon merged commit 121b5a3 into main Feb 23, 2024
6 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/cli/warn-when-shared-schemes-fail-to-be-resolved branch February 23, 2024 15:10
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentvatne brentvatne brentvatne approved these changes

@byCedric byCedric Awaiting requested review from byCedric byCedric is a code owner

Assignees
No one assigned
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EvanBacon @brentvatne @expo-bot