Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Integrate native views with bridgeless mode #27289

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Feb 26, 2024

Why

Follow up to #27242 but for native views

How

  • Introduced getViewConfig method in the core module that returns a static view config
  • Replaced the standard requireNativeComponent with a custom one that uses the getViewConfig for registration
  • Fixed uses of bridge.uiManager for bridgeless – the dot syntax doesn't work in the bridge proxy, we need to invoke it as a method ([bridge uiManager]).
  • uiManager.methodQueue is no longer available in the RCTUIManagerProxy, I used RCTGetUIManagerQueue() instead.
  • I decided to raise an exception in addUIBlock: and executeUIBlock: whose block receives the view registry. The registry is now always empty in the New Architecture and shouldn't really be used anywhere. Other versions of these two methods are still available.

Test Plan

Tested in fabric-tester (new arch) and bare-expo (old arch)

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Feb 26, 2024
Base automatically changed from @tsapeta/ios/bridgeless to main February 27, 2024 10:36
@tsapeta tsapeta force-pushed the @tsapeta/ios/bridgeless-view-configs branch from 0850a39 to d6ff067 Compare February 27, 2024 17:29
@tsapeta tsapeta force-pushed the @tsapeta/ios/bridgeless-view-configs branch 5 times, most recently from ccde95a to 19f6e08 Compare February 27, 2024 22:01
@tsapeta tsapeta force-pushed the @tsapeta/ios/bridgeless-view-configs branch from 19f6e08 to 304424a Compare March 5, 2024 19:58
@expo-bot
Copy link
Collaborator

expo-bot commented Mar 5, 2024

The Pull Request introduced fingerprint changes against the base commit: 8057542

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-dev-launcher",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "4d2200a12fb27dc4648bfc87ccb85ef58b9b69e8"
  }
]

Generated by PR labeler 🤖

@tsapeta tsapeta force-pushed the @tsapeta/ios/bridgeless-view-configs branch from 304424a to 4560f45 Compare March 5, 2024 22:43
@tsapeta tsapeta force-pushed the @tsapeta/ios/bridgeless-view-configs branch from 4560f45 to ef4b313 Compare March 5, 2024 22:50
@tsapeta tsapeta marked this pull request as ready for review March 5, 2024 23:12
@tsapeta tsapeta removed the request for review from douglowder March 5, 2024 23:12
Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@expo-bot
Copy link
Collaborator

expo-bot commented Mar 6, 2024

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against e1f88e7

@tsapeta tsapeta merged commit c1a550e into main Mar 6, 2024
12 checks passed
@tsapeta tsapeta deleted the @tsapeta/ios/bridgeless-view-configs branch March 6, 2024 17:15
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: suggestions ExpoBot has some suggestions published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants