-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Integrate native views with bridgeless mode #27289
Conversation
de365f0
to
60f0562
Compare
0850a39
to
d6ff067
Compare
ccde95a
to
19f6e08
Compare
19f6e08
to
304424a
Compare
The Pull Request introduced fingerprint changes against the base commit: 8057542 Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-dev-launcher",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "4d2200a12fb27dc4648bfc87ccb85ef58b9b69e8"
}
] Generated by PR labeler 🤖 |
304424a
to
4560f45
Compare
4560f45
to
ef4b313
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
Why
Follow up to #27242 but for native views
How
getViewConfig
method in the core module that returns a static view configrequireNativeComponent
with a custom one that uses thegetViewConfig
for registrationbridge.uiManager
for bridgeless – the dot syntax doesn't work in the bridge proxy, we need to invoke it as a method ([bridge uiManager]
).uiManager.methodQueue
is no longer available in theRCTUIManagerProxy
, I usedRCTGetUIManagerQueue()
instead.addUIBlock:
andexecuteUIBlock:
whose block receives the view registry. The registry is now always empty in the New Architecture and shouldn't really be used anywhere. Other versions of these two methods are still available.Test Plan
Tested in fabric-tester (new arch) and bare-expo (old arch)