[android][location] Fix exception when service is missing on api 34 #27355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Pull Request introduced fingerprint changes against the base commit: 7386599 Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-location/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "144a78981541bd6f0d8b29d166f30e5062cb59a5"
}
]Generated by PR labeler 🤖 |
expo-bot
added
bot: passed checks
lukmccall
approved these changes
Feb 28, 2024
alanjhughes
deleted the
@alanhughes/location/fix-service-missing-exception
branch
brentvatne
pushed a commit
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #27336
How
Only repros when full background permissions are granted (Always allow). Added a check for the required permissions and prevent the service from starting if they are missing.
Test Plan
bare-expo