Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-launcher] remove flipper workaround #27508

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Mar 7, 2024

Why

noticed some flipper stuff in adb log when running bare-expo on android because flipper classes not found. since flipper are removed now, we could also remove the previous workaround #18105

How

remove flipper relevant code

Test Plan

ci passed

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 7, 2024
@Kudo Kudo force-pushed the @kudo/remove-flipper-dev-launcher branch from 801af6f to 623eb97 Compare March 7, 2024 20:08
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 7, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Mar 7, 2024

The Pull Request introduced fingerprint changes against the base commit: 3d2157c

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-dev-launcher",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "c619b75193d4926a14e6f84785ca8e13cfa3066c"
  }
]

Generated by PR labeler 🤖

@Kudo Kudo marked this pull request as ready for review March 8, 2024 06:08
@Kudo Kudo merged commit 5cfc95b into main Mar 11, 2024
9 checks passed
@Kudo Kudo deleted the @kudo/remove-flipper-dev-launcher branch March 11, 2024 15:10
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants