[ios][camera] Fix initial orientation #27545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Pull Request introduced fingerprint changes against the base commit: 433746c Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-camera/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "079f8487760665167da8899c283c46b30c1e532e"
}
]Generated by PR labeler 🤖 |
expo-bot
added
bot: passed checks
tsapeta
approved these changes
Mar 9, 2024
alanjhughes
force-pushed
the
@alanhughes/camera/fix-initial-orientation
branch
from
822cac1
to
14a5c36
Compare
alanjhughes
added a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #27218
In both versions of the package we were checking for the initial orientation too early. At a time when the video buffers were not yet connected.
How
Moved the call to correct the orientation after we have connected the inputs. Also fixed a number of other small warnings and removed dead code. I've backported the fix to old camera.
Test Plan
Bare-expo and provided repro.