Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios][camera] Ensure mute prop value is provided #27546

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

alanjhughes
Copy link
Collaborator

@alanjhughes alanjhughes commented Mar 9, 2024

Why

Closes #27494

How

Provide the mute prop to native whether the user provides it or not to ensure the default value is correctly set and native will remove the audio inputs

Test Plan

bare-expo

@alanjhughes alanjhughes changed the title [ios][camera] Ensure mute prop value is provided [camera] Ensure mute prop value is provided Mar 9, 2024
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 9, 2024
@alanjhughes alanjhughes marked this pull request as ready for review March 9, 2024 17:12
@alanjhughes alanjhughes requested a review from tsapeta March 9, 2024 17:12
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 9, 2024
@alanjhughes alanjhughes changed the title [camera] Ensure mute prop value is provided [ios][camera] Ensure mute prop value is provided Mar 9, 2024
@alanjhughes alanjhughes merged commit 433746c into main Mar 10, 2024
7 of 8 checks passed
@alanjhughes alanjhughes deleted the @alanhughes/camera/mute-prop branch March 10, 2024 13:57
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[expo-camera/next][IOS]: The default mute=false is not working
4 participants