[contacts] Fix editing contacts on both platforms #27703
Conversation
alanjhughes
changed the title
expo-bot
added
the
bot: needs changes
|
The Pull Request introduced fingerprint changes against the base commit: 95979d9 Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-contacts/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "129a3e15597a251889f1b7730db954330afec1b0"
},
{
"type": "dir",
"filePath": "../../packages/expo-contacts/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "f72977a185d46dcc53ef3bb8b576e49519bb32a8"
}
]Generated by PR labeler 🤖 |
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇 ❌ Error: SwiftLint Violations
Generated by ExpoBot 🤖 against 816a7aa |
| @@ -70,22 +70,22 @@ public class ContactsModule: Module { | |||
| } | |||
| }.runOnQueue(.main) | |||
|
|
|||
| AsyncFunction("presentFormAsync") { (identifier: String?, data: Contact, options: FormOptions, promise: Promise) in | |||
| AsyncFunction("presentFormAsync") { (identifier: String?, data: Contact?, options: FormOptions, promise: Promise) in | |||
There was a problem hiding this comment.
🔴 SwiftLint: Closure Body Length Violation
Closure body should span 50 lines or less excluding comments and whitespace: currently spans 53 lines
| promise.resolve() | ||
| } | ||
|
|
||
| OnActivityResult { _, payload -> |
There was a problem hiding this comment.
@alanjhughes This seems to be a new API in the module definition? Could this be documented in the official docs?
There was a problem hiding this comment.
@fobos531 It's been there since the beginning. I hadn't realised it was undocumented. Will get that added 👍
|
I'm confused about the release of this fix. I'm currently on the latest version 12.8.2 of the module |
Why
Noticed some issues with expo-contacts while looking at something else. Editing wasn't working on either platform because one of the arguments is nullable in JS but it wasn't in native so the method calls always failed when null was passed. Also fixed another issue on iOS where sharing was not working correctly.
How
contactargument topresentFormAsyncnullable on both platformsTest Plan
bare-expo and NCL
All tests are passing and the example screen works correctly now.