migrate to @react-native/normalize-colors #27736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: suggestions
Kudo
requested review from
ide,
tsapeta,
lukmccall,
aleqsio,
douglowder,
gabrieldonadel and
wschurman
as code owners
Kudo
removed request for
wschurman,
ide,
tsapeta,
aleqsio,
douglowder,
lukmccall and
gabrieldonadel
Kudo
force-pushed
the
@kudo/rn074/migrate-normalize-colors
branch
from
9bbf8ff
to
0bc410d
Compare
github-actions
bot
added
bot: fingerprint compatible
and removed
bot: fingerprint changed
labels
tsapeta
approved these changes
Mar 19, 2024
| @@ -42,6 +42,7 @@ | |||
| "@expo/config-types": "^51.0.0-unreleased", | |||
| "@expo/image-utils": "^0.4.0", | |||
| "@expo/json-file": "^8.3.0", | |||
| "@react-native/normalize-colors": "~0.74.75", | |||
There was a problem hiding this comment.
haha there was an accident when publishing these monorepo @react-native packages.
Kudo
commented
Mar 19, 2024
| @@ -3519,12 +3519,12 @@ | |||
| hermes-parser "0.19.1" | |||
| nullthrows "^1.1.1" | |||
|
|
|||
| "@react-native/normalize-color@^2.0.0", "@react-native/normalize-color@^2.1.0": | |||
| "@react-native/normalize-color@^2.1.0": | |||
There was a problem hiding this comment.
note: this remaining dependency is coming from react-native-web
lukmccall
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
i found that we still use the
@react-native/normalize-colorand not update to the 0.74 versioned@react-native/normalize-colorspackagesHow
migrate our code from
@react-native/normalize-colorto@react-native/normalize-colorsTest Plan
ci passed
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).