[core][dev-menu] fix nightlies testing for 0.75 #27773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
fix breaking changes for nightlies testing (0.75.0-nightly-20240319-d97741af6)
How
upstream changes:
LongLivedObjectCollection::get()
should pass runtime facebook/react-native@3706bf0CallInvoker()
has new parameter for runtime: facebook/react-native@76ce789ReactActivityDelegate::createRootView()
may return null facebook/react-native@da21799this pr includes:
ReactActivityHandler.createReactRootView()
since this is not used for bridgeless modeDevMenuActivity.createRootView()
. rather than get root view fromsuper.createRootView()
. let's get root view frommReactDelegate.reactRootView
after loadApp()Test Plan
bunx create-expo-nightly --expo-repo /path/to/expo/expo
. there is a build error from HermesExecutorFactory.h. i've reached out to meta that the include is not reachable by cocoapods. i have to manually modify the include.Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).