Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][dev-menu] fix nightlies testing for 0.75 #27773

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Mar 20, 2024

Why

fix breaking changes for nightlies testing (0.75.0-nightly-20240319-d97741af6)

How

upstream changes:

this pr includes:

  • moving testing SyncCallInvoker to shared TestingSyncJSCallInvoker
  • remove unused ReactActivityHandler.createReactRootView() since this is not used for bridgeless mode
  • slightly change DevMenuActivity.createRootView(). rather than get root view from super.createRootView(). let's get root view from mReactDelegate.reactRootView after loadApp()

Test Plan

  • ci passed
  • tested on an app generated by bunx create-expo-nightly --expo-repo /path/to/expo/expo. there is a build error from HermesExecutorFactory.h. i've reached out to meta that the include is not reachable by cocoapods. i have to manually modify the include.

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 20, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Mar 20, 2024

The Pull Request introduced fingerprint changes against the base commit: 0ff9c52

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-dev-menu",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "4c2440f978f65669f0076a8843d56cd8b663441b"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo-modules-core/android",
    "reasons": [
      "expoAutolinkingAndroid"
    ],
    "hash": "8c2983660d9a46c161b7a909bc8c0d8944bf28e5"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo/android",
    "reasons": [
      "expoAutolinkingAndroid"
    ],
    "hash": "a9fbbfc84924f63703fd2ed64ef50d0c486ba425"
  }
]

Generated by PR labeler 🤖

@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 20, 2024
@Kudo Kudo marked this pull request as ready for review March 21, 2024 07:01
@Kudo Kudo merged commit d06aad9 into main Mar 21, 2024
21 checks passed
@Kudo Kudo deleted the @kudo/fix-nightlies-20240320 branch March 21, 2024 12:02
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants