[expo-calendar] Use typescript enums instead of objects for enumerable types #27777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behenate
force-pushed
the
@behenate/calendar-use-enums
branch
from
05c52e3
to
24fee47
Compare
expo-bot
added
bot: passed checks
behenate
force-pushed
the
@behenate/calendar-use-enums
branch
from
24fee47
to
75fc819
Compare
behenate
requested review from
Simek,
amandeepmittal,
lukmccall and
alanjhughes
as code owners
lukmccall
approved these changes
Mar 21, 2024
behenate
force-pushed
the
@behenate/calendar-use-enums
branch
from
75fc819
to
96212ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently
expo-calendarallows usage of any string for many enum values. This causes issues like this one: #27513.How
Updated the
objectbased enum values into TSenumtypes. Ideally we would use an Union, but this would introduce some issues with correctly deprecating the old types and backwards compatibility.Test Plan
IDEs don't allow putting a random string into the fields now :)