[sensors] Fix maximum call stack size exceeded due to a new EventEmitter #28149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
force-pushed
the
@tsapeta/fix-sensors
branch
from
105cce0
to
189d2dd
Compare
expo-bot
added
bot: passed checks
tsapeta
force-pushed
the
@tsapeta/fix-sensors
branch
from
189d2dd
to
349a78c
Compare
lukmccall
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We're getting
RangeError: Maximum call stack size exceededwhen removing the subscription from the sensors. This is because expo-sensors is doing some weird things with the EventEmitter class 馃槄How
npx expo-modules-test-core generate-ts-mocksso it works well with the changes I made in [jest] Clean up EventEmitter mock and use NativeModule class聽#28158Test Plan
Tested on Accelerometer and Sensors screens in NCL