feat(haptics): add rigid and soft impact types
#28169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodperottoni
requested review from
Simek,
amandeepmittal and
lukmccall
as code owners
expo-bot
added
bot: passed checks
lukmccall
reviewed
Apr 15, 2024
Comment on lines
+10
to
+24
| "soft" to HapticsVibrationType( | ||
| longArrayOf(0, 50), | ||
| intArrayOf(0, 30), | ||
| longArrayOf(0, 20) | ||
| ), | ||
| "medium" to HapticsVibrationType( | ||
| longArrayOf(0, 43), | ||
| intArrayOf(0, 50), | ||
| longArrayOf(0, 43) | ||
| ), | ||
| "rigid" to HapticsVibrationType( | ||
| longArrayOf(0, 43), | ||
| intArrayOf(0, 50), | ||
| longArrayOf(0, 43) | ||
| ), |
There was a problem hiding this comment.
I'm not sure if we should tune values for the new options 🤔
There should be one in the changeset already 😃 |
lukmccall
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Since iOS 13 two new impact styles have been added:
softandrigid. I'd like to use these impact styles in my expo-powered app but currently can't without a patch.How
iOS: I simply added the new impact types to the existing Swift Module
Android: I don't know what an equivalent of
softandrigidimpact types would feel like on Android, so I simply used the existinglight/mediumas the equivalent ofsoft/rigid.Test Plan
This can only be tested on a real device.
Run the
native-component-listapp on a real device and go to the Haptics screen. Tap the "Soft" and "Rigid" buttons.Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).native-component-listproject was updated with the new APIs