[notifications][Android] Fix events not being sent to js #28207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Pull Request introduced fingerprint changes against the base commit: 89dea54 Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-notifications/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "e3d15556f80c815f68672b6437de734bda6116c5"
}
]Generated by PR labeler 🤖 |
tsapeta
approved these changes
Apr 15, 2024
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
lukmccall
deleted the
@lukmccall/notification/fix-notifications-listeners
branch
expo-bot
added
bot: passed checks
douglowder
pushed a commit
that referenced
this pull request
Jun 12, 2024
# Why Fixes events not being sent to js because native code uses the incorrect emitter. Closes ENG-11898. # Test plan - https://github.com/douglowder/NotificationsTest/tree/canary ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes events not being sent to js because native code uses the incorrect emitter.
Closes ENG-11898.
Test plan