[screen-capture] Fix crash on bridgeless #28244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Pull Request introduced fingerprint changes against the base commit: b30d376 Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-screen-capture/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "aec51f980b0e08b59e09ec7b98ed9a8bf6617e2d"
}
]Generated by PR labeler 🤖 |
expo-bot
added
bot: passed checks
lukmccall
approved these changes
Apr 17, 2024
lukmccall
reviewed
Apr 17, 2024
| @@ -32,7 +33,6 @@ class ScreenCaptureModule : Module() { | |||
| screenCaptureCallback = Activity.ScreenCaptureCallback { | |||
| sendEvent(eventName) | |||
| } | |||
| currentActivity.registerScreenCaptureCallback(currentActivity.mainExecutor, screenCaptureCallback!!) | |||
There was a problem hiding this comment.
I believe that, in theory, the current activity should be available at this point. Maybe it's connected with #28200? I'm okay with merging your fix, but generally speaking, I don't like that the order of initialization was changed.
There was a problem hiding this comment.
It could be. AFAIK it's an upstream issue that Kudo has brought up with them. I just made this change for now because this is the only module that stops the app from running on bridgeless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes a crash on bridgeless caused by accessing the activity too early
How
Refactored to register the listener when the user first uses the api.
Test Plan
bare-expo on bridgeless. Crash does not occur and the module works as expected