[core][updates] fix Updates.reloadAsync not working on ios #28256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
Kudo
requested review from
wschurman,
douglowder,
tsapeta and
lukmccall
as code owners
tsapeta
approved these changes
Apr 17, 2024
wschurman
approved these changes
Apr 17, 2024
3 tasks
douglowder
approved these changes
Apr 17, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Updates.reloadAsync() does not use the latest bundleURL on ios. it's a regression from #27601
close ENG-11975
How
before #27601, the
RCTBridgeDelegate.sourceURLForBridge:is inside expo-updates. it's no longer the case since #27601 and we were using the cached bundleURL inside RCTRootViewFactory. that's why reload still using the previous bundleURL.this pr tries to introduce a new
bundleURLhandler to react delegate handlers to override. then expo-updates could serve the newer bundleURL.Test Plan
test https://github.com/expo/UpdatesAPIDemo/tree/canary.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).