Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-calendar] [iOS] Don't check calendar permissions for saving reminders, and fix missing details when saving calendar events #28265

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

robertying
Copy link
Contributor

Why

expo-calendar is broken on iOS with the latest canary build. Issues I have found so far:

  • Calendar event title and color is not being saved properly.
  • Calendar event endDate is always the same as startDate.
  • The module checks for calendar permissions even when saving reminders.

How

Added the missing code and fixes.

Test Plan

  • Call createEventAsync or createReminderAsync with all the details and the correct events/reminders are saved in Calendar or Reminders.
  • Request only for reminder permissions and try to call createReminderAsync doesn't throw with the missing permission error.

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 17, 2024
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 17, 2024
Copy link
Collaborator

@alanjhughes alanjhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅ Thanks for the contribution! 👍

@alanjhughes alanjhughes merged commit 8c58d10 into expo:main Apr 17, 2024
20 checks passed
@robertying robertying deleted the fix-ios-calendar branch April 17, 2024 22:28
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants