Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[av][Android] Fix HashMap cannot be cast to ReadableNativeMap error #28317

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

lukmccall
Copy link
Contributor

Why

Fixed the HashMap cannot be cast to ReadableNativeMap error

How

It was caused by changes in the way we convert legacy argument types.

Test Plan

  • NCL ✅
  • test suite ✅

@lukmccall lukmccall requested a review from Kudo as a code owner April 19, 2024 10:35
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 19, 2024
@expo-bot
Copy link
Collaborator

The Pull Request introduced fingerprint changes against the base commit: ff73778

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-av/android",
    "reasons": [
      "expoAutolinkingAndroid"
    ],
    "hash": "b81c9b5f7507ea2749ff230e771c6bfaed217589"
  }
]

Generated by PR labeler 🤖

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@lukmccall lukmccall merged commit 813a721 into main Apr 19, 2024
1 check passed
@lukmccall lukmccall deleted the @lukmccall/av/fix-cannot-convert branch April 19, 2024 11:59
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants