[android][media-library] fix promise resolved twice #28323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The block in actionIfUserGrantedPermission was still executed even if permission was denied, resulting in the passed promise being resolved twice.
mathieupost
requested review from
tsapeta,
lukmccall and
alanjhughes
as code owners
expo-bot
added
bot: passed checks
tsapeta
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
After #28212 was merged, the block in actionIfUserGrantedPermission was still executed even if permission was denied, resulting in the passed promise being resolved twice.
How
The
blockis now only evaluated if permission was granted.Test Plan
By running the MediaLibrary tests in the bare-app, when rejecting the permission to modify assets, no log should appear about a promise being resolved twice.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).