-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sqlite] bump sqlite to 3.45.3 and enable bytecodevtab #28358
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: suggestions
ExpoBot has some suggestions
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Apr 22, 2024
The Pull Request introduced fingerprint changes against the base commit: eb59156 Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-sqlite/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "2c88fd80fa1688e0c37e2197a4b73935db875acc"
},
{
"type": "dir",
"filePath": "../../packages/expo-sqlite/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "f9a9a513c1f3c4590de780b51d6a2c5b5491ea78"
},
{
"type": "dir",
"filePath": "ios",
"reasons": [
"bareNativeDir"
],
"hash": "ad8cd97095952a647202b3e83a0dbcc292d57c46"
}
] Generated by PR labeler 🤖 |
Kudo
requested review from
wschurman,
douglowder and
alanjhughes
as code owners
April 22, 2024 17:34
Kudo
force-pushed
the
@kudo/sqlite-bytecodevtab
branch
from
April 22, 2024 18:43
0c5d353
to
9e836ff
Compare
i'm go ahead to merge this beforehand for sdk 51 to include the feature. feel free to comment if there's anything from post-review. |
alanjhughes
approved these changes
Apr 22, 2024
Sorry for the delay @Kudo looks good 👍 |
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
since sqlite3.podspec
3.45.3+1
has thesqlite3/bytecodevtab
subspec support. we can now enableSQLITE_ENABLE_BYTECODE_VTAB
for all sqlite libsHow
Test Plan
launch expo-go/bare-expo and call the function to check whether
{"compile_options": "ENABLE_BYTECODE_VTAB"}
is existedChecklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).