Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqlite] bump sqlite to 3.45.3 and enable bytecodevtab #28358

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Apr 22, 2024

Why

since sqlite3.podspec 3.45.3+1 has the sqlite3/bytecodevtab subspec support. we can now enable SQLITE_ENABLE_BYTECODE_VTAB for all sqlite libs

How

Test Plan

launch expo-go/bare-expo and call the function to check whether {"compile_options": "ENABLE_BYTECODE_VTAB"} is existed

async function loadBuildFlagsAsync() {
  const db = await SQLite.openDatabaseAsync('test.db');
  const result = await db.getAllAsync<any>('PRAGMA compile_options');
  console.log('SQLite compile options:', result);
}

Checklist

@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 22, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Apr 22, 2024

The Pull Request introduced fingerprint changes against the base commit: eb59156

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-sqlite/android",
    "reasons": [
      "expoAutolinkingAndroid"
    ],
    "hash": "2c88fd80fa1688e0c37e2197a4b73935db875acc"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo-sqlite/ios",
    "reasons": [
      "expoAutolinkingIos"
    ],
    "hash": "f9a9a513c1f3c4590de780b51d6a2c5b5491ea78"
  },
  {
    "type": "dir",
    "filePath": "ios",
    "reasons": [
      "bareNativeDir"
    ],
    "hash": "ad8cd97095952a647202b3e83a0dbcc292d57c46"
  }
]

Generated by PR labeler 🤖

@Kudo Kudo marked this pull request as ready for review April 22, 2024 17:34
@Kudo Kudo force-pushed the @kudo/sqlite-bytecodevtab branch from 0c5d353 to 9e836ff Compare April 22, 2024 18:43
@Kudo
Copy link
Contributor Author

Kudo commented Apr 22, 2024

i'm go ahead to merge this beforehand for sdk 51 to include the feature. feel free to comment if there's anything from post-review.

@Kudo Kudo merged commit d80bdbb into main Apr 22, 2024
22 of 23 checks passed
@Kudo Kudo deleted the @kudo/sqlite-bytecodevtab branch April 22, 2024 18:49
@alanjhughes
Copy link
Collaborator

Sorry for the delay @Kudo looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants